HDDS-15345. Make GetBucketLocation return NotImplemented Response#10332
Open
fmorg-git wants to merge 1 commit into
Open
HDDS-15345. Make GetBucketLocation return NotImplemented Response#10332fmorg-git wants to merge 1 commit into
fmorg-git wants to merge 1 commit into
Conversation
adoroszlai
reviewed
May 22, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @fmorg-git for the patch.
| return null; | ||
| } | ||
|
|
||
| context.setAction(S3GAction.GET_BUCKET); |
Contributor
There was a problem hiding this comment.
Can you please add a new GET_BUCKET_LOCATION constant in S3GAction?
Comment on lines
+52
to
+54
| final OS3Exception ex = assertThrows(OS3Exception.class, () -> bucketEndpoint.get(BUCKET_NAME)); | ||
| assertEquals(HTTP_NOT_IMPLEMENTED, ex.getHttpCode()); | ||
| assertEquals("NotImplemented", ex.getCode()); |
Contributor
There was a problem hiding this comment.
nit: this can be simplified:
import static org.apache.hadoop.ozone.s3.endpoint.EndpointTestUtils.assertErrorResponse;
...
assertErrorResponse(S3ErrorTable.NOT_IMPLEMENTED, () -> bucketEndpoint.get(BUCKET_NAME));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15345
How was this patch tested?
tested with Postman and aws s3 api cli