HDDS-15838. Add container export shared types, config, and proto#10737
HDDS-15838. Add container export shared types, config, and proto#10737sarvekshayr wants to merge 2 commits into
Conversation
|
@szetszwo @devmadhuu @ArafatKhan2198 Please review the PR. |
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @sarvekshayr for the patch. Largely LGTM +1. Just a nit.
|
|
||
| private final String jobId; | ||
| private final State state; | ||
| private final String lifecycleState; |
There was a problem hiding this comment.
Better use same enum as LifeCycleState only here.
There was a problem hiding this comment.
Updated to LifeCycleState and ContainerHealthState.
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@sarvekshayr , thanks for working on this!
Without the usage, there are no way to review if the conf/proto/contants are good.
- Proto and other constants should be added with the usage.
- Add Conf at the last JIRA. Hard code the values and add TODO for now.
Usually, we change the server side first since we can test it by calling the methods directly (instead of using RPC). Once the server is working, we may add Client RPC/proto, and then CLI.
|
Added server-side export implementation (export manager + tests + shared types with usage) in #10813 as per review feedback. Closing this now. |
3 participants
What changes were proposed in this pull request?
Adds shared types, SCM configuration, and SCM client protocol messages for async export. No server implementation, client wiring, or CLI in this PR.
Part 3 of 5 in splitting HDDS-15496 #10673 container ID export.
What is the link to the Apache JIRA
HDDS-15838
How was this patch tested?
CI: https://github.com/sarvekshayr/ozone/actions/runs/29226836517
Made with Cursor to help split the container ID export.