HDDS-14520. Add shared components for service UIs#10787
Conversation
|
@jshukla01 could you take a look at this PR as well? |
|
@ivandika3 @ArafatKhan2198 I know this is a very large patch but mostly it is safe code that is not being referenced anywhere for now. @arunsarin85 could you also take a look at this PR? |
There was a problem hiding this comment.
Thanks for putting the shared component foundation together. Centralising the design tokens, theme and recurring UI elements is the right direction.
I found a few issues that could be addressed before these components become shared contracts:
- The Sidebar logo points to
/shared/icons/favicon.ico, but that asset is not emitted by the current shared-package or Vite build configuration. - The shared Sidebar still hardcodes application routes, branding and header state, so it is not reusable across OM, SCM and Recon.
Sidebarimportsreact-router-dom, but the shared package does not declare it as a dependency or peer dependency.- The directory move deletes the UI
.gitignore, leavingnode_modulesanddistunignored. TextLinkallows callers to override the safe attributes added byexternal={true}.- The workspace root uses Vite 6 while the application packages continue using Vite
Please let me know if any of the comments are wrong, or If I have missed out on a few things.
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for addressing the review comments @spacemonkd
I verified the latest changes, and the previously reported issues have been resolved
Changed LGTM +1
|
Thanks @ArafatKhan2198 for the review, merging this. |
What changes were proposed in this pull request?
HDDS-14520. Add shared components for service UIs
Please describe your PR in detail:
There are some components which are commonly used across various UIs, for example Cards, Chips, Sidebar etc.
This PR adds those components in a shared folder from which we can reuse them for all the UIs.
It also simplifies the directory structure and I used Claude Haiku 4.5 to clean up the README file for the module.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14520
How was this patch tested?
Patch was tested manually by creating a test page using the card component and the common theme.