HDDS-15716. Replace layout version protos with new version-named protos in the DN–SCM protocol#10817
Open
dombizita wants to merge 3 commits into
Open
HDDS-15716. Replace layout version protos with new version-named protos in the DN–SCM protocol#10817dombizita wants to merge 3 commits into
dombizita wants to merge 3 commits into
Conversation
…os in the DN–SCM protocol
github-actions
Bot
added
the
zdu
errose28
reviewed
Jul 20, 2026
errose28
left a comment
errose28
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this @dombizita. Most comments are minor, but there's some improvements we can do to existing behavior as well.
errose28
approved these changes
Jul 23, 2026
errose28
left a comment
errose28
left a comment
Contributor
There was a problem hiding this comment.
Only nonfunctional comments on some stale commets/javadoc I found. Otherwise good to merge.
| @@ -375,10 +375,10 @@ void processNodeReport(DatanodeDetails datanodeDetails, | |||
| * Process Node LayoutVersion report. | |||
Contributor
There was a problem hiding this comment.
This javadoc needs to be updated.
| @@ -653,11 +653,11 @@ public void processNodeReport(DatanodeDetails dnUuid, | |||
| * Empty implementation for processLayoutVersionReport. | |||
Contributor
There was a problem hiding this comment.
This javadoc is also stale.
Contributor
There was a problem hiding this comment.
The javadoc on processVersionReport is stale. We can update it in this PR.
| // SCM. | ||
| versionInfo = toVersionProto(INITIAL_VERSION, INITIAL_VERSION); | ||
| } | ||
| // Datanode version will be fenced during registration. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Datanode version will be fenced during registration. | |
| // Datanodes which do not report a version will not be allowed to register. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current proto uses the old terminology in the names. We will have one non-rolling upgrade before ZDU is released where we can deprecate this proto and switch to a new one without any extra compatibility handling.
In this patch I switched
LayoutVersionPrototoDatanodeVersionProtoandFinalizeNewLayoutVersionCommandPrototoFinalizeNewDatanodeVersionCommandProto.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15716
How was this patch tested?
Green CI on my fork: https://github.com/dombizita/ozone/actions/runs/29577100863
Used Claude Opus 4.8 for the refactoring, review and adjustments by me.