HDDS-15688. Retain in-memory PAUSED state when diskBalancer.info write fails on DN state change#10818
Merged
Merged
Conversation
Gargi-jais11
marked this pull request as ready for review
July 20, 2026 09:04
slfan1989
approved these changes
Jul 20, 2026
Contributor
|
LGTM +1 |
Contributor
Author
|
Thanks @ayushtkn @slfan1989 @rich7420 for reviewing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes a bug where DiskBalancer could keep running on a datanode that is being decommissioned or put into maintenance.
When the datanode state changed, DiskBalancer correctly switched to PAUSED in memory. If saving that state to diskBalancer.info failed, the code switched back to RUNNING. That means container moves could continue on a node that should have stopped background work.
Fix applied :
On persist failure in
nodeStateUpdated():What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15688
How was this patch tested?
Added unit test.