Skip to content

HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization#10863

Open
errose28 wants to merge 2 commits into
apache:HDDS-14496-zdufrom
errose28:HDDS-15966-flaky-finalize-test
Open

HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization#10863
errose28 wants to merge 2 commits into
apache:HDDS-14496-zdufrom
errose28:HDDS-15966-flaky-finalize-test

Conversation

@errose28

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Failed here with a timeout at:

	at org.apache.ozone.test.GenericTestUtils.waitFor(GenericTestUtils.java:137)
	at org.apache.hadoop.hdds.upgrade.HddsUpgradeTestUtils.waitForScmToFinalize(HddsUpgradeTestUtils.java:125)
	at org.apache.hadoop.hdds.upgrade.HddsUpgradeTestUtils.waitForScmsToFinalize(HddsUpgradeTestUtils.java:119)
	at org.apache.hadoop.hdds.upgrade.TestScmHAFinalization.testSnapshotFinalization(TestScmHAFinalization.java:173)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:511)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1450)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2019)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)

Logs show that it timed out waiting for scm2 to exit safemode. Safemode exit is this is no longer required for SCM finalization in the new upgrade framework, it is only required to instruct OMs to finalize which is not covered by this test. We can remove the safemode check from the wait.

What is the link to the Apache JIRA

HDDS-15966

How was this patch tested?

100 runs on my fork: https://github.com/errose28/ozone/actions/runs/30111725666/job/89543515225
This run was built off #10678 in case the failure was caused by the PR's changes. The test passed with a fix independent of the PR though.

@errose28
errose28 requested a review from dombizita July 24, 2026 17:52
@github-actions github-actions Bot added the zdu Pull requests for Zero Downtime Upgrade (ZDU) https://issues.apache.org/jira/browse/HDDS-14496 label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

zdu Pull requests for Zero Downtime Upgrade (ZDU) https://issues.apache.org/jira/browse/HDDS-14496

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant