HDDS-14905. Followups from HDDS-14672#9983
Merged
errose28 merged 3 commits intoapache:HDDS-14496-zdufrom Mar 30, 2026
Merged
Conversation
github-actions
bot
added
the
zdu
errose28
reviewed
Mar 27, 2026
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
One minor thing otherwise LGTM.
.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java
Outdated
Show resolved
Hide resolved
errose28
approved these changes
Mar 30, 2026
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
LGTM. CI failure on follower read is unrelated and we're on a feature branch so merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There were some "post commit" review comments on HDDS-14672, so addressing them in this Jira. #9955 (review)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14905
How was this patch tested?
Existing tests