perf: avoid expanding Mosaic row selections#421
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Keep Mosaic row selections as row-group-local slices instead of materializing one UInt64 index per selected row. Apply selected ranges with RecordBatch slicing and concat while preserving empty projection row counts. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Mosaic row selection previously expanded each selected row range into a
UInt64Arrayof per-row indices before applyingtake. For large contiguous ranges, this makes memory and CPU cost proportional to the selected row count even though the input is already range-based.Brief change log
(offset, len)slices.RecordBatch::slice.concat_batches.Tests
cargo clippy --all-targets --workspace --features fulltext,vortex,mosaic -- -D warningscargo test -p paimon --all-targets --features fulltext,vortex,mosaic test_mosaiccargo test -p paimon --all-targets --features fulltext,vortex,mosaic arrow::format::mosaic::testsAPI and Format
Documentation