Align TableCommit with FileStoreCommit commit semantics#422
Open
JingsongLi wants to merge 7 commits into
Open
Conversation
QuakeWang
reviewed
Jun 29, 2026
leaves12138
approved these changes
Jun 29, 2026
leaves12138
left a comment
There was a problem hiding this comment.
LGTM. Reviewed the latest head, including the manifest rolling and compression follow-up commits. I also ran cargo fmt --all -- --check and cargo test -p paimon table::table_commit --no-fail-fast locally on 6f41f30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align Rust
TableCommitmore closely with Python/JavaFileStoreCommitcommit behavior where the underlying Rust writer/commit contracts match. This adds manifest rolling and minor compaction, overwrite retry caching, richer latest-snapshot conflict checks, row-tracking parity for dedicated files, and column-aware global index update handling.Changes
min_row_id/max_row_idmetadata when all entries carry row ids.file_source, blob files, and vector dedicated files.DROP_PARTITION_INDEXsupport, includingextra_field_ids.Testing
cargo fmt --allcargo test -p paimon table::table_commit --no-fail-fast -- --nocapturecargo test -p paimon --lib --no-fail-fastgit diff --checkNotes
table_commitcoverage was expanded with Python-inspired regression tests for overwrite cache reuse/rebuild, manifest rolling/minor compaction, global index extra-field updates, and default-partition null overwrite behavior.check_from_snapshotpath is intentionally not mirrored here because Rust currently does not carry the same read-snapshot contract intoCommitMessage; keeping a public field without a reliable producer would imply stronger conflict detection than Rust actually has.