[python] Advance overwrite changes cache on retry#8368
Open
JingsongLi wants to merge 1 commit into
Open
Conversation
abe516e to
6cd6612
Compare
6cd6612 to
39dabb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up #8358 by extending the overwrite-specific retry cache.
OverwriteChangesProvidernow advances its cached target-partition state with intervening raw delta entries, so overwrite retries do not rebuild the DELETE list with another full scan when those deltas can be applied safely.Relates to #8359.
Changes
FileEntry.merge_entries.Testing
PYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/overwrite_changes_cache_test.py -qPYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/overwrite_commit_conflict_test.py -qPYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/file_store_commit_test.py -qPYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/partition_predicate_test.py -qPYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/write/conflict_detection_test.py -qPYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/table_commit_test.py -qPYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/manifest/manifest_manager_test.py -qPYTHONPATH=paimon-python python -m py_compile paimon-python/pypaimon/write/commit/overwrite_changes_provider.py paimon-python/pypaimon/tests/overwrite_changes_cache_test.pygit diff --checkNotes
The generic commit retry base-state reuse is already handled by #8358. This PR is intentionally scoped to overwrite commit-entry construction and only changes
OverwriteChangesProviderplus its cache tests.