[vector] Support VectorType in common row paths#8370
Open
QuakeWang wants to merge 2 commits into
Open
Conversation
Support VectorType in RowToColumnConverter with a heap vector column vector that preserves fixed-size dense child offsets, including nullable parent vectors. Also add compacted row serialization for vector fields and reject vector fields from key/comparator paths. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
VectorTypewas not supported in common row-to-column conversion and compacted row serialization. This left common data paths incomplete for vector columns, and nullable vector columns also need to preserve fixed-size dense child offsets for vectorized consumers such as Arrow writers.This PR adds a heap vector column vector, supports
VectorTypeinRowToColumnConverterandRowCompactedSerializer, and rejects vector fields from key/comparator paths because vectors are not comparable.Tests
mvn -pl paimon-common -Dtest=RowToColumnConverterTest#testConvertVectorType+testConvertNullableVectorType+testConvertVectorTypeWithInvalidLength+testConvertVectorTypeWithNullElement testmvn -pl paimon-common -DfailIfNoTests=false '-Dtest=RowCompactedSerializerTest$VectorTypesTest' testmvn -pl paimon-core -Dtest=SchemaValidationTest#testVectorTypeCanNotBeKey testmvn -pl paimon-arrow -am -DfailIfNoTests=false -Dtest=ArrowVectorizedBatchConverterTest#testNullableVectorColumnFromRowToColumnConverter test