Skip to content

[WIP] use getLong when matching byte sequences in ByteString#2323

Closed
pjfanning wants to merge 3 commits intoapache:mainfrom
pjfanning:bs-getLong
Closed

[WIP] use getLong when matching byte sequences in ByteString#2323
pjfanning wants to merge 3 commits intoapache:mainfrom
pjfanning:bs-getLong

Conversation

@pjfanning
Copy link
Copy Markdown
Member

@pjfanning pjfanning commented Oct 18, 2025

Copy link
Copy Markdown
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WIP] The simpler approach compared to #2324. Using getLong for byte sequence matching is straightforward and likely provides good performance for most cases.

Recommendation: Same as #2324 -- benchmark this against the Two-Way approach and merge the winner. The MiMa issue mentioned in the description ('package private method causing a mima issue') can be handled with exclusion filters.

@pjfanning pjfanning closed this Apr 19, 2026
@pjfanning pjfanning deleted the bs-getLong branch April 19, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants