fix(common): avoid mutating query AST during fingerprinting#18443
Open
wolfkill wants to merge 1 commit into
Open
fix(common): avoid mutating query AST during fingerprinting#18443wolfkill wants to merge 1 commit into
wolfkill wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18443 +/- ##
============================================
- Coverage 63.65% 63.64% -0.01%
Complexity 1735 1735
============================================
Files 3254 3254
Lines 199446 199434 -12
Branches 30977 30972 -5
============================================
- Hits 126953 126934 -19
- Misses 62356 62358 +2
- Partials 10137 10142 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18426
Tests
git diff --checkJAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH ./mvnw -pl pinot-common -am -Dtest=org.apache.pinot.common.utils.request.QueryFingerprintUtilsTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false testThe targeted Maven run completed with 37 QueryFingerprintUtilsTest tests passing and checkstyle enabled across the affected reactor modules.