Skip to content

adding support for unauthenticated access from pinot to HDFS #18508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pri1712 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding support for unauthenticated access from pinot to HDFS #18508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ...ile-system/pinot-hdfs/src/main/java/org/apache/pinot/plugin/filesystem/HadoopPinotFS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ public class HadoopPinotFS extends BasePinotFS {
private static final String KEYTAB = "hadoop.kerberos.keytab";
private static final String HADOOP_CONF_PATH = "hadoop.conf.path";
private static final String WRITE_CHECKSUM = "hadoop.write.checksum";
private static final String GLOBAL_HADOOP_USER = "hadoop.user.name";
private static final String ALLOW_INSECURE = "hadoop.allow.insecure";

private org.apache.hadoop.fs.FileSystem _hadoopFS = null;
private org.apache.hadoop.conf.Configuration _hadoopConf;
Expand All @@ -63,7 +65,20 @@ public HadoopPinotFS() {
public void init(PinotConfiguration config) {
try {
_hadoopConf = getConf(config.getProperty(HADOOP_CONF_PATH));
authenticate(_hadoopConf, config);
boolean allowInsecure = Boolean.parseBoolean(config.getProperty(ALLOW_INSECURE, "false"));

if (!allowInsecure) {
authenticate(_hadoopConf, config);
} else {
String globalHadoopUser = config.getProperty(GLOBAL_HADOOP_USER);
if (Strings.isNullOrEmpty(globalHadoopUser)) {
throw new RuntimeException("HADOOP_USER must be provided when ALLOW_INSECURE is true");
}

UserGroupInformation ugi = UserGroupInformation.createRemoteUser(globalHadoopUser);
UserGroupInformation.setLoginUser(ugi);
LOGGER.info("Setting HDFS login user to: {}", globalHadoopUser);
}
_hadoopFS = org.apache.hadoop.fs.FileSystem.get(_hadoopConf);
_hadoopFS.setWriteChecksum((config.getProperty(WRITE_CHECKSUM, false)));
LOGGER.info("successfully initialized HadoopPinotFS");
Expand Down
16 changes: 16 additions & 0 deletions ...system/pinot-hdfs/src/test/java/org/apache/pinot/plugin/filesystem/HadoopPinotFSTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,4 +452,20 @@ public void testDeleteBatchPerformanceWithManyFiles()
hadoopFS.delete(baseURI, true);
}
}

@Test
public void testInitWithUnauthenticatedUser()
throws IOException {
String testUser = "pinot-test-user-" + System.currentTimeMillis();

PinotConfiguration config = new PinotConfiguration();
config.setProperty("hadoop.allow.insecure", "true");
config.setProperty("hadoop.user.name", testUser);

try (HadoopPinotFS hadoopFS = new HadoopPinotFS()) {
hadoopFS.init(config);
String currentUser = org.apache.hadoop.security.UserGroupInformation.getLoginUser().getUserName();
Assert.assertEquals(currentUser, testUser, "The Hadoop login user was not set correctly!");
}
}
}