Emit topic name in ingestion delay metrics#18509
Open
rseetham wants to merge 1 commit into
Open
Conversation
Include the Kafka topic name as part of the ingestion delay gauge metric name so that operators can distinguish metrics by topic when a table has multiple upstream streams or when a topic is renamed. - Add `setOrUpdatePartitionTopicGauge` / `removePartitionTopicGauge` to AbstractMetrics, composing the metric name as <gauge>.<table>.<partition>.<topic>. - Update IngestionDelayTracker.createMetrics / removeMetrics to use the new topic-aware APIs, looking up the topic name from the StreamConfig. - Rename RealtimeTableDataManager.getHostedPartitionsGroupIds → getHostedConsumingPartitionsGroupIds to clarify that only CONSUMING segments are returned. - Add unit tests in AbstractMetricsTest and IngestionDelayTrackerTest covering the new APIs and verifying the topic name appears in the metric name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the Kafka topic name as part of the ingestion delay gauge metric name so that operators can distinguish metrics by topic when a table has multiple upstream streams.
setOrUpdatePartitionTopicGauge/removePartitionTopicGaugeto AbstractMetrics, composing the metric name as ....