[ISSUE #10465] Preserve suspend flag when rewriting POP revive retry records#10466
Open
yx9o wants to merge 1 commit into
Open
[ISSUE #10465] Preserve suspend flag when rewriting POP revive retry records#10466yx9o wants to merge 1 commit into
yx9o wants to merge 1 commit into
Conversation
yx9o
commented
Jun 10, 2026
yx9o
commented
Contributor
- Fixes [Enhancement] Preserve suspend flag when rewriting POP revive retry records #10465 .
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10466 +/- ##
=============================================
- Coverage 48.05% 47.99% -0.06%
+ Complexity 13309 13291 -18
=============================================
Files 1377 1377
Lines 100632 100635 +3
Branches 12995 12995
=============================================
- Hits 48362 48304 -58
- Misses 46338 46388 +50
- Partials 5932 5943 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10466 — Preserve suspend flag when rewriting POP revive retry records
Type: Bug fix (4 files, +23/-4)
Assessment
Fixes POP messaging retry semantics:
- Copies suspend flag in backoff rewrite paths
- Preserves suspend in KV-to-FS transfer
- Prevents suspended retries from being treated as normal retries
Verdict
✅ Important correctness fix for POP messaging. Fixes #10465.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.