[ISSUE #10462] Add memory backpressure to dispatch#10470
Open
lizhimins wants to merge 1 commit into
Open
Conversation
… cap 1GB) - Add tieredStoreDispatchMinFreeMemoryRatio (default 0.1) and tieredStoreDispatchMinFreeMemoryMaxBytes (default 1GB) config - Add isMemoryEnough() check before dispatch to prevent OOM - Remove Dispatcher semaphore, rely on thread pool natural throttling - Rename dispatchWithSemaphore to dispatch Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10470 +/- ##
=============================================
- Coverage 48.03% 47.99% -0.05%
- Complexity 13286 13295 +9
=============================================
Files 1376 1377 +1
Lines 100558 100645 +87
Branches 12985 12996 +11
=============================================
- Hits 48305 48302 -3
- Misses 46333 46397 +64
- Partials 5920 5946 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10470 — Add memory backpressure to dispatch
Type: Enhancement (3 files, +51/-15)
Assessment
Adds memory backpressure mechanism to prevent OOM:
- Configurable min free memory ratio (default 0.1)
- Max bytes cap (default 1GB)
- isMemoryEnough() check before dispatch
- Removes Dispatcher semaphore, relies on thread pool throttling
Verdict
✅ Critical stability improvement for tiered storage. Part of #10462.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of #10462
Add memory backpressure mechanism to the tiered storage dispatcher. When available heap memory falls below the configured threshold, dispatch is skipped to prevent OOM.
Brief changelog
tieredStoreDispatchMinFreeMemoryRatio(default 0.1) andtieredStoreDispatchMinFreeMemoryMaxBytes(default 1GB) configisMemoryEnough()check before dispatchdispatchWithSemaphoretodispatchVerifying this change
mvn compilesucceedsmvn test -pl tieredstorepasses (112 tests, 0 failures)🤖 Generated with Claude Code