[ISSUE #10462] Fix concurrency bugs in tiered storage#10471
Open
lizhimins wants to merge 1 commit into
Open
Conversation
- PosixFileSegment: use read(ByteBuffer, long) for atomic reads - IndexStoreFile: hash & 0x7FFFFFFF to prevent MIN_VALUE overflow - IndexStoreFile: held flag fixes unmatched mappedFile.release() - IndexStoreFile: >= maxCount fixes off-by-one in query results - IndexStoreFile: timeDiff clamped to [0, Integer.MAX_VALUE] - IndexStoreFile: slotBuffer moved outside loop with position reset - FlatCommitLogFile: local variable snapshot for firstOffset TOCTOU - FlatMessageFile: add volatile to topicMetadata/queueMetadata - CommitLogInputStream: fix buffer assignment order Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10471 +/- ##
=============================================
- Coverage 48.03% 47.96% -0.08%
+ Complexity 13286 13280 -6
=============================================
Files 1376 1377 +1
Lines 100558 100635 +77
Branches 12985 12996 +11
=============================================
- Hits 48305 48265 -40
- Misses 46333 46421 +88
- Partials 5920 5949 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10471 — Fix concurrency bugs in tiered storage
Type: Bug fix (5 files, +23/-14)
Assessment
Fixes critical concurrency issues in tiered storage:
- FileChannel race condition (atomic reads)
- Hash overflow (MIN_VALUE handling)
- Off-by-one error in query results
- TOCTOU issues with firstOffset
Verdict
✅ Important concurrency fixes that prevent data corruption. Part of #10462.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of #10462
Fix concurrency bugs including FileChannel race condition, hash overflow, off-by-one, and TOCTOU issues.
Brief changelog
read(ByteBuffer, long)for atomic reads& 0x7FFFFFFFto prevent MIN_VALUE overflowheldflag fixes unmatchedmappedFile.release()>= maxCountfixes off-by-one in query resultstimeDiffclamped to[0, Integer.MAX_VALUE]slotBuffermoved outside loop with position resetvolatiletotopicMetadata/queueMetadataVerifying this change
mvn compilesucceedsmvn test -pl tieredstorepasses (112 tests, 0 failures)🤖 Generated with Claude Code