[ISSUE #10462] Optimize thread pool sizes#10472
Open
lizhimins wants to merge 1 commit into
Open
Conversation
…executors - Reduce core pool from max(16, processors*4) to max(4, processors) - Set max pool to max(16, processors*2) instead of equal to core - Allows idle thread recycling (keepAliveTime=1min was already set) - Extract processors variable to avoid repeated calls Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10472 +/- ##
=============================================
- Coverage 48.03% 47.98% -0.06%
+ Complexity 13286 13283 -3
=============================================
Files 1376 1377 +1
Lines 100558 100633 +75
Branches 12985 12995 +10
=============================================
- Hits 48305 48284 -21
- Misses 46333 46406 +73
- Partials 5920 5943 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10472 — Optimize thread pool sizes
Type: Performance (1 file, +8/-7)
Assessment
Reduces core pool from max(16, processors*4) to max(4, processors), sets max pool to max(16, processors*2). Eliminates excessive idle threads.
Verdict
✅ Reasonable thread pool tuning. Part of #10462.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of #10462
Optimize thread pool sizes for commit and fetch executors to reduce idle thread count while maintaining throughput.
Brief changelog
max(16, processors*4)tomax(4, processors)max(16, processors*2)instead of equal to corekeepAliveTime=1minwas already set)processorsvariable to avoid repeatedRuntime.getRuntime()callsVerifying this change
mvn compilesucceedsmvn test -pl tieredstorepasses (112 tests, 0 failures)🤖 Generated with Claude Code