[ISSUE #10462] Improve error handling in tiered storage#10473
Open
lizhimins wants to merge 1 commit into
Open
Conversation
- TieredMessageStore: unwrap CompletionException, re-throw Error - PosixFileSegment: throw RuntimeException on IOException in read0 - FlatAppendFile: getFileCorrectSize bounded 3-retry instead of infinite loop - FlatAppendFile: add GET_TIMESTAMP_ERROR constant, use in getMin/MaxTimestamp - FileSegment: readAsync uses local snapshot of commitPosition - FileSegmentFactory: include provider name/type/path in RuntimeException - FlatMessageFile: commitAsync uses tryAcquire instead of drainPermits - IndexStoreService: check fileSegmentList empty before accessing last element - IndexStoreService: delete corrupted local files during recover Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10473 — Improve error handling in tiered storage
Type: Bug fix (7 files, +34/-25)
Assessment
Prevents silent data corruption: unwraps CompletionException, re-throws Error, throws RuntimeException on IOException in read0.
Verdict
✅ Critical error handling improvements. Part of #10462.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of #10462
Improve error handling to prevent silent data corruption and propagate fatal errors.
Brief changelog
CompletionException, re-throwErrorRuntimeExceptionon IOException inread0getFileCorrectSizebounded 3-retry instead of infinite loopGET_TIMESTAMP_ERRORconstant, use ingetMin/MaxTimestampreadAsyncuses local snapshot ofcommitPositionRuntimeExceptioncommitAsyncusestryAcquireinstead ofdrainPermitsfileSegmentListempty before accessing last elementVerifying this change
mvn compilesucceedsmvn test -pl tieredstorepasses (112 tests, 0 failures)🤖 Generated with Claude Code