[ISSUE #10462] Standardize log format across tiered storage#10474
Open
lizhimins wants to merge 1 commit into
Open
[ISSUE #10462] Standardize log format across tiered storage#10474lizhimins wants to merge 1 commit into
lizhimins wants to merge 1 commit into
Conversation
- Unify to ClassName#methodName, description, key={} format
- Fix wrong class name IndexStoreService in IndexStoreFile logs
- Fix SLF4J placeholder count mismatches and missing commas
- Fix trailing whitespace and dangling colons in format strings
- Fix runtime string concatenation in IndexStoreService shutdown log
- Change error to warn for graceful skip scenarios in IndexStoreService
- Change info to debug for normal flow logs (file full, boundary search)
- Fix log order in FileSegment readAsync (log length before reassignment)
- Deduplicate queryMessageAsync error logs with context parameters
- Enhance MessageFormatUtil splitMessageBuffer logs with buffer details
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10474 +/- ##
=============================================
- Coverage 48.03% 48.02% -0.02%
- Complexity 13286 13302 +16
=============================================
Files 1376 1377 +1
Lines 100558 100636 +78
Branches 12985 12997 +12
=============================================
+ Hits 48305 48331 +26
- Misses 46333 46368 +35
- Partials 5920 5937 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10474 — Standardize log format across tiered storage
Type: Code quality (11 files, +94/-92)
Assessment
Unifies log format to ClassName#methodName, description, key={} pattern. Fixes wrong class names and SLF4J placeholder issues.
Verdict
✅ Improves troubleshooting consistency. Part of #10462.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of #10462
Standardize log format across the tiered storage module for consistent troubleshooting.
Brief changelog
ClassName#methodName, description, key={}formatIndexStoreServicein IndexStoreFile logserrortowarnfor graceful skip scenariosinfotodebugfor normal flow logs (file full, boundary search)readAsync(log length before reassignment)queryMessageAsyncerror logs with context parameterssplitMessageBufferlogs with buffer detailsVerifying this change
mvn compilesucceedsmvn test -pl tieredstorepasses (112 tests, 0 failures)🤖 Generated with Claude Code