[ISSUE #10462] Fix resource leaks and lifecycle issues#10476
Open
lizhimins wants to merge 1 commit into
Open
Conversation
…d storage - FileSegment close() waits for in-flight commit (30s timeout) - PosixFileSegment stores RAF references to prevent handle leaks - MessageStoreExecutor shutdown adds awaitTermination(30s) - Remove MessageStoreExecutor singleton pattern - Remove fileRecyclingExecutor (wrong thread name, unused) - Change MessageStoreExecutor fields from public to private with getters - FlatFileFactory removes test constructor that leaked thread pool - FlatMessageFile removes dead inFlightRequestMap field - TieredMessageStore reorders shutdown: dispatcher->index->executor->file->next - Update all tests to pass executor to FlatFileFactory and shutdown in @after Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10476 +/- ##
=============================================
- Coverage 48.03% 48.01% -0.03%
- Complexity 13286 13301 +15
=============================================
Files 1376 1377 +1
Lines 100558 100646 +88
Branches 12985 12999 +14
=============================================
+ Hits 48305 48325 +20
- Misses 46333 46380 +47
- Partials 5920 5941 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10476 — Fix resource leaks and lifecycle issues
Type: Bug fix (18 files, +108/-63)
Assessment
Fixes resource leaks in tiered storage: FileSegment close() waits for in-flight commits, PosixFileSegment stores RAF references to prevent handle leaks, MessageStoreExecutor shutdown improvements.
Verdict
✅ Solid resource management fixes. Part of #10462.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of #10462
Fix resource leaks and improve lifecycle management in tiered storage module.
Brief changelog
close()waits for in-flight commit (30s timeout)shutdown(): addawaitTermination(30s)fileRecyclingExecutor(wrong thread name, unused)inFlightRequestMapfieldVerifying this change
mvn compilesucceedsmvn test -pl tieredstorepasses (112 tests, 0 failures)🤖 Generated with Claude Code