[ISSUE #10475] Add unit tests for CleanupPolicyUtils#10477
Open
quzizii wants to merge 1 commit into
Open
Conversation
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10477 — Add unit tests for CleanupPolicyUtils
Type: Test coverage (1 file, +145)
Assessment
Comprehensive test coverage for CleanupPolicyUtils covering default policy fallback, null/empty attributes, explicit DELETE/COMPACTION policies, and compaction detection.
Verdict
✅ Well-structured tests. Fixes #10475.
🤖 Automated review by oss-sentinel-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Add unit tests for
CleanupPolicyUtils.The added tests cover cleanup policy resolution from
TopicConfigattributes, including:TopicConfigis absentnullor emptycleanup.policyis missingDELETEpolicyCOMPACTIONpolicyisCompaction()behavior for compaction and non-compaction casesThis PR only adds regression tests and does not change production logic.
How Did You Test This Change?
Run unit tests locally and verified all tests pass successfully.