Skip to content

test: strengthen IP address utility assertions #10649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Loyal-Young wants to merge 1 commit into
base: develop
Choose a base branch
from
+84 −83
Open

test: strengthen IP address utility assertions #10649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
167 changes: 84 additions & 83 deletions common/src/test/java/org/apache/rocketmq/common/utils/IPAddressUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,92 +1,93 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.rocketmq.common.utils;

/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.rocketmq.common.utils;
import org.junit.Test;

import static org.assertj.core.api.Assertions.assertThat;
import static org.apache.rocketmq.common.utils.NetworkUtil.validCommonInet6Address;

public class IPAddressUtilsTest {

@Test
public void isIPInRange() {

// IPv4 test
String ipv4Address = "192.168.1.10";
String ipv4Cidr = "192.168.1.0/24";
assert IPAddressUtils.isIPInRange(ipv4Address, ipv4Cidr);
public class IPAddressUtilsTest {
@Test
public void isIPInRange() {
// IPv4 test
String ipv4Address = "192.168.1.10";
String ipv4Cidr = "192.168.1.0/24";
assertThat(IPAddressUtils.isIPInRange(ipv4Address, ipv4Cidr)).isTrue();

ipv4Address = "192.168.2.10";
assert !IPAddressUtils.isIPInRange(ipv4Address, ipv4Cidr);

// IPv6 test
String ipv6Address = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
String ipv6Cidr = "2001:0db8:85a3::/48";
assert IPAddressUtils.isIPInRange(ipv6Address, ipv6Cidr);
}

@Test
public void isValidCidr() {
String ipv4Cidr = "192.168.1.0/24";
String ipv6Cidr = "2001:0db8:1234:5678::/64";
String invalidCidr = "192.168.1.0";

assert IPAddressUtils.isValidCidr(ipv4Cidr);
assert IPAddressUtils.isValidCidr(ipv6Cidr);
assert !IPAddressUtils.isValidCidr(invalidCidr);
}

@Test
public void isValidIp() {
String ipv4 = "192.168.1.0";
String ipv6 = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
String invalidIp = "192.168.1.256";
String ipv4Cidr = "192.168.1.0/24";

assert IPAddressUtils.isValidIp(ipv4);
assert IPAddressUtils.isValidIp(ipv6);
assert !IPAddressUtils.isValidIp(invalidIp);
assert !IPAddressUtils.isValidIp(ipv4Cidr);
}

@Test
public void isValidIPOrCidr() {
String ipv4 = "192.168.1.0";
String ipv6 = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
String ipv4Cidr = "192.168.1.0/24";
String ipv6Cidr = "2001:0db8:1234:5678::/64";
assert IPAddressUtils.isValidIPOrCidr(ipv4);
assert IPAddressUtils.isValidIPOrCidr(ipv6);
assert IPAddressUtils.isValidIPOrCidr(ipv4Cidr);
assert IPAddressUtils.isValidIPOrCidr(ipv6Cidr);
}

@Test
public void isValidIPv6Common() {
String ipv6WithoutScope = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
assert validCommonInet6Address(ipv6WithoutScope);
assertThat(IPAddressUtils.isIPInRange(ipv4Address, ipv4Cidr)).isFalse();
// IPv6 test
String ipv6Address = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
String ipv6Cidr = "2001:0db8:85a3::/48";
assertThat(IPAddressUtils.isIPInRange(ipv6Address, ipv6Cidr)).isTrue();
}
@Test
public void isValidCidr() {
String ipv4Cidr = "192.168.1.0/24";
String ipv6Cidr = "2001:0db8:1234:5678::/64";
String invalidCidr = "192.168.1.0";
assertThat(IPAddressUtils.isValidCidr(ipv4Cidr)).isTrue();
assertThat(IPAddressUtils.isValidCidr(ipv6Cidr)).isTrue();
assertThat(IPAddressUtils.isValidCidr(invalidCidr)).isFalse();
}
@Test
public void isValidIp() {
String ipv4 = "192.168.1.0";
String ipv6 = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
String invalidIp = "192.168.1.256";
String ipv4Cidr = "192.168.1.0/24";
assertThat(IPAddressUtils.isValidIp(ipv4)).isTrue();
assertThat(IPAddressUtils.isValidIp(ipv6)).isTrue();
assertThat(IPAddressUtils.isValidIp(invalidIp)).isFalse();
assertThat(IPAddressUtils.isValidIp(ipv4Cidr)).isFalse();
}
@Test
public void isValidIPOrCidr() {
String ipv4 = "192.168.1.0";
String ipv6 = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
String ipv4Cidr = "192.168.1.0/24";
String ipv6Cidr = "2001:0db8:1234:5678::/64";
assertThat(IPAddressUtils.isValidIPOrCidr(ipv4)).isTrue();
assertThat(IPAddressUtils.isValidIPOrCidr(ipv6)).isTrue();
assertThat(IPAddressUtils.isValidIPOrCidr(ipv4Cidr)).isTrue();
assertThat(IPAddressUtils.isValidIPOrCidr(ipv6Cidr)).isTrue();
}
@Test
public void isValidIPv6Common() {
String ipv6WithoutScope = "2001:0db8:85a3:0000:0000:8a2e:0370:7334";
assertThat(validCommonInet6Address(ipv6WithoutScope)).isTrue();
String ipv6WithScope = "2001:0db8:85a3:0000:0000:8a2e:0370:7334%eth0";
assert validCommonInet6Address(ipv6WithScope);
assertThat(validCommonInet6Address(ipv6WithScope)).isTrue();
String ipv6WithBracketedAndScope = "[2001:0db8:85a3:0000:0000:8a2e:0370:7334%eth0]";
assert validCommonInet6Address(ipv6WithBracketedAndScope);
assertThat(validCommonInet6Address(ipv6WithBracketedAndScope)).isTrue();
String ipv4 = "192.168.1.0";
assert !validCommonInet6Address(ipv4);
assertThat(validCommonInet6Address(ipv4)).isFalse();
String ipv4Cidr = "192.168.1.0/24";
assert !validCommonInet6Address(ipv4Cidr);
}

}
assertThat(validCommonInet6Address(ipv4Cidr)).isFalse();
}
}