[SPARK-57183][SS][4.2] Close LRUCache on RocksDB.close() in unbounded memory mode#56281
Open
kete1987 wants to merge 1 commit into
Open
[SPARK-57183][SS][4.2] Close LRUCache on RocksDB.close() in unbounded memory mode#56281kete1987 wants to merge 1 commit into
kete1987 wants to merge 1 commit into
Conversation
…ry mode ### What changes were proposed in this pull request? In unbounded memory mode (the default, `boundedMemoryUsage = false`), `RocksDBMemoryManager` creates a new `LRUCache` per instance: https://github.com/apache/spark/blob/d7df1920cfb8577c17a9b1555592d3772f061417/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBMemoryManager.scala#L185 but `RocksDB.close()` never calls `lruCache.close()`: https://github.com/apache/spark/blob/d7df1920cfb8577c17a9b1555592d3772f061417/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala#L2125-L2135 The Java `LRUCache` wrapper holds a C++ `shared_ptr<Cache>`, so the native object is only freed when the JVM GC finalizes the wrapper — which rarely happens under low heap pressure. This causes native memory to accumulate until GC eventually runs, leading to OOM kills in long-running processes or CI runs with many RocksDB-heavy test suites. The fix adds an explicit `lruCache.close()` call in `RocksDB.close()` for unbounded mode. In bounded mode the cache is a shared singleton managed by `RocksDBMemoryManager` and must not be closed per instance. This is a separate issue from SPARK-56523 (Statistics native memory leak), which was already fixed. ### Why are the changes needed? Without explicit `close()`, each `RocksDB` instance in unbounded mode leaks one `LRUCache` worth of native memory (`blockCacheSizeMB`, default 8 MB) for as long as GC does not run. The memory is never reclaimed deterministically. A standalone reproducer tool confirms ~8.5 MB of native memory growth per open/close cycle in leak mode vs flat memory in fixed mode: https://github.com/kete1987/rocksdb-leak-tool ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added a test in `RocksDBSuite` (`SPARK-57183: LRUCache is closed on RocksDB.close() in unbounded memory mode`) that verifies the native handle is released after `close()` via `LRUCache.isOwningHandle()`. ### Was this patch authored or co-authored using generative AI tooling? Co-authored with Claude (Anthropic), used for analysis, code generation and review assistance. Generated-by: Claude Sonnet 4.6 I affirm that the contribution is my original work and that I license the work to the project under the project's open source license. Closes apache#56234 from kete1987/SPARK-57183-rocksdb-lrucache-leak. Authored-by: Ivan Morales <kete1987@gmail.com> Signed-off-by: Anish Shrigondekar <anish.shrigondekar@databricks.com>
Contributor
Author
|
@anishshri-db this is a backport of #56234 to branch-4.2. Please merge whenever convenient. |
Contributor
Do we need the backport for 4.2 ? Usually we only merge critical fixes to cut branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport of #56234 to branch-4.2.
Why are the changes needed?
See #56234.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
See #56234.
Was this patch authored or co-authored using generative AI tooling?
Co-authored with Claude (Anthropic), used for analysis, code generation and review assistance.
Generated-by: Claude Sonnet 4.6