[SPARK-57281][SQL][SS] Remove @Experimental annotation from Real-time mode#56346
Open
jerrypeng wants to merge 1 commit into
Open
[SPARK-57281][SQL][SS] Remove @Experimental annotation from Real-time mode#56346jerrypeng wants to merge 1 commit into
jerrypeng wants to merge 1 commit into
Conversation
… Mode trigger APIs Remove the @experimental annotation from the public Real-time Mode trigger APIs -- the Trigger.RealTime(...) overloads in Trigger.java and the RealTimeTrigger case class and companion object in Triggers.scala -- and drop the now-unused org.apache.spark.annotation.Experimental import from both files.
dongjoon-hyun
requested changes
Jun 5, 2026
Member
There was a problem hiding this comment.
Although I understand what you mean, it's a little misleading because we use Stable annotation for the stable APIs, @jerrypeng . The whole Trigger class is Evolving. So, RTM APIs falls in Evolving instead of Stable. Could you revise the PR description?
Remove @experimental since the RTM APIs are stable now.
RTM APIs are stable now
Contributor
Author
|
@dongjoon-hyun thank you for the review! I have fixed the PR description. PTAL! |
dongjoon-hyun
approved these changes
Jun 5, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you so much, @jerrypeng .
viirya
approved these changes
Jun 5, 2026
Member
|
This is only for 4.3.0, right? |
HyukjinKwon
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove @experimental since the RTM APIs as they are no longer experimental and to make them consistent with other triggers supported in structured streaming.
Why are the changes needed?
RTM APIs are no longer experimental.
Does this PR introduce any user-facing change?
No
How was this patch tested?
n/a
Was this patch authored or co-authored using generative AI tooling?
Co-authored with Claude