[SPARK-58308][INFRA] Remove usage of ipython_genutils#57478
Open
gaogaotiantian wants to merge 3 commits into
Open
[SPARK-58308][INFRA] Remove usage of ipython_genutils#57478gaogaotiantian wants to merge 3 commits into
gaogaotiantian wants to merge 3 commits into
Conversation
HyukjinKwon
approved these changes
Jul 24, 2026
uros-b
reviewed
Jul 25, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
@gaogaotiantian PTAL at dev/spark-test-image/lint/Dockerfile:92, this might be an incomplete removal vs. the PR's stated goal. Master has exactly three ipython_genutils references; the PR removes the two in spark-rm/Dockerfile and docs/Dockerfile but leaves the third, 'ipython_genutils' \ at lint/Dockerfile:92 (confirmed still present at head ref d480bb0). The lint image is not dead, it is actively built and used by CI (.github/workflows/build_and_test.yml:511-515 builds from ./dev/spark-test-image/lint/).
Contributor
Author
|
Thanks for catching this @uros-b . I removed it for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed all usage of
ipython_genutils.Why are the changes needed?
This package was originally introduced by SPARK-38517 because of jupyter/nbconvert#1725 . However,
ipython_genutilshas not been maintained for 10 years andnbconvertquickly removed the usage and dependency of it. So now our doc gen CI should not rely on it either.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI should confirm that we don't need it anymore.
Was this patch authored or co-authored using generative AI tooling?
No.