[SPARK-58312][PYTHON] Remove unnecessary type: ignore comments in pyspark.sql.udf and group#57482
Open
Spenserrrr wants to merge 1 commit into
Open
[SPARK-58312][PYTHON] Remove unnecessary type: ignore comments in pyspark.sql.udf and group#57482Spenserrrr wants to merge 1 commit into
Spenserrrr wants to merge 1 commit into
Conversation
Contributor
Author
…park.sql.udf and group
Spenserrrr
force-pushed
the
haotian-sun_data/typeignore2
branch
from
July 24, 2026 01:10
7bb5e98 to
2b2f413
Compare
uros-b
approved these changes
Jul 24, 2026
Member
|
LGTM, thank you @Spenserrrr! also, cc @HyukjinKwon @Yicong-Huang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Several # type: ignore comments in python/pyspark/sql/udf.py and python/pyspark/sql/group.py can be removed by fixing the underlying type issues:
Why are the changes needed?
To improve readability
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests. mypy --config-file python/mypy.ini python/pyspark passes at full scope.
Was this patch authored or co-authored using generative AI tooling?
No