fix(tests): restore 100% TypeScript coverage for core packages#38682
fix(tests): restore 100% TypeScript coverage for core packages#38682michael-s-molina merged 2 commits intomasterfrom
Conversation
Add tests for the GranularExportControls feature flag introduced in #38361, which caused the core-packages-ts codecov check to drop from 100% to 99.92%. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review Agent Run #56e164Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Sequence DiagramThis PR adds targeted unit tests for the new GranularExportControls feature flag. The tests verify both the enum string mapping and that the flag is recognized as enabled when present in window feature flags, restoring full TypeScript coverage. sequenceDiagram
participant TestRunner
participant FeatureFlagEnum
participant BrowserWindow
participant FeatureCheck
TestRunner->>FeatureFlagEnum: Read GranularExportControls value
FeatureFlagEnum-->>TestRunner: GRANULAR_EXPORT_CONTROLS
TestRunner->>BrowserWindow: Set featureFlags with GRANULAR_EXPORT_CONTROLS true
TestRunner->>FeatureCheck: Call isFeatureEnabled with GranularExportControls
FeatureCheck->>BrowserWindow: Read feature flag state
FeatureCheck-->>TestRunner: Return true and assertion passes
Generated by CodeAnt AI |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Bito Automatic Review Skipped – PR Already Merged |
…e#38682) Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: Joe Li <joe@preset.io>
…e#38682) Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: Joe Li <joe@preset.io>
…e#38682) Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: Joe Li <joe@preset.io>
Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: Joe Li <joe@preset.io>
User description
SUMMARY
The
codecov/project/core-packages-tscheck has been failing on every PR since #38361, which added theGranularExportControlsfeature flag to theFeatureFlagenum but didn't add corresponding tests. This caused the coverage to drop from 100% to 99.92%.This follows the same pattern as #38518 (which previously achieved 100% coverage): add explicit tests for any new feature flag enum members to keep the
core-packages-tscoverage check green.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
npm run core:coverinsuperset-frontend/— should pass with 100% coveragecodecov/project/core-packages-tsCI check should go back to 100%ADDITIONAL INFORMATION
CodeAnt-AI Description
Add tests for GranularExportControls feature flag to restore 100% core TypeScript coverage
What Changed
Impact
✅ Stable 100% TypeScript coverage for core packages✅ Fewer CI coverage failures✅ Clearer feature-flag behavior for export controls💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.