Skip to content

refactor(e2e): model dashboard filter bar#42017

Draft
sadpandajoe wants to merge 2 commits into
masterfrom
codex/refactor-playwright-filter-bar
Draft

refactor(e2e): model dashboard filter bar#42017
sadpandajoe wants to merge 2 commits into
masterfrom
codex/refactor-playwright-filter-bar

Conversation

@sadpandajoe

Copy link
Copy Markdown
Member

SUMMARY

Follow up on #42013 by bringing the remaining Clear All regression flow into the Playwright page-object/component model:

  • add a DashboardFilterBar component that composes the existing Button and Select primitives and owns the native-filter selectors/actions
  • have DashboardPage compose and expose the filter bar while preserving its existing applyFiltersIfEnabled API
  • keep clear-all-filters.spec.ts focused on scenario setup, network observation, and behavioral assertions
  • replace the untyped request listener with Playwright's Request type

This centralizes UI knowledge without moving scenario-specific assertions or API asset setup into page objects.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable; this is a Playwright test-architecture refactor with no product UI change.

TESTING INSTRUCTIONS

pre-commit run --files \
  superset-frontend/playwright/components/dashboard/DashboardFilterBar.ts \
  superset-frontend/playwright/components/dashboard/index.ts \
  superset-frontend/playwright/pages/DashboardPage.ts \
  superset-frontend/playwright/tests/dashboard/clear-all-filters.spec.ts

cd superset-frontend
npx playwright test \
  playwright/tests/dashboard/clear-all-filters.spec.ts \
  playwright/tests/dashboard/delete-display-control.spec.ts \
  --list --workers=1

Targeted formatting, lint, custom frontend rules, and frontend type-check pass. The required pre-commit run --all-files was also executed; its failures are unrelated checkout-wide baseline/environment issues (existing mapper-test mypy errors, absent docs eslint, unbuilt package declarations, and existing Ruff findings).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.05%. Comparing base (a2a7176) to head (0a200e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #42017   +/-   ##
=======================================
  Coverage   65.05%   65.05%           
=======================================
  Files        2747     2747           
  Lines      153761   153761           
  Branches    35249    35249           
=======================================
+ Hits       100026   100027    +1     
+ Misses      51825    51824    -1     
  Partials     1910     1910           
Flag Coverage Δ
javascript 70.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 8785ac7
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a56b77a86956d000944fd9a
😎 Deploy Preview https://deploy-preview-42017--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant