refactor(e2e): model dashboard filter bar#42017
Draft
sadpandajoe wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #42017 +/- ##
=======================================
Coverage 65.05% 65.05%
=======================================
Files 2747 2747
Lines 153761 153761
Branches 35249 35249
=======================================
+ Hits 100026 100027 +1
+ Misses 51825 51824 -1
Partials 1910 1910
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up on #42013 by bringing the remaining Clear All regression flow into the Playwright page-object/component model:
DashboardFilterBarcomponent that composes the existingButtonandSelectprimitives and owns the native-filter selectors/actionsDashboardPagecompose and expose the filter bar while preserving its existingapplyFiltersIfEnabledAPIclear-all-filters.spec.tsfocused on scenario setup, network observation, and behavioral assertionsRequesttypeThis centralizes UI knowledge without moving scenario-specific assertions or API asset setup into page objects.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; this is a Playwright test-architecture refactor with no product UI change.
TESTING INSTRUCTIONS
Targeted formatting, lint, custom frontend rules, and frontend type-check pass. The required
pre-commit run --all-fileswas also executed; its failures are unrelated checkout-wide baseline/environment issues (existing mapper-test mypy errors, absent docs eslint, unbuilt package declarations, and existing Ruff findings).ADDITIONAL INFORMATION