Skip to content

fix(dashboard): prevent result set overlap in mixed chart View as Table#42018

Open
MallikarjunaReddyN wants to merge 1 commit into
apache:masterfrom
MallikarjunaReddyN:fix/mixed-chart-view-as-table-tabs-result-overlap
Open

fix(dashboard): prevent result set overlap in mixed chart View as Table#42018
MallikarjunaReddyN wants to merge 1 commit into
apache:masterfrom
MallikarjunaReddyN:fix/mixed-chart-view-as-table-tabs-result-overlap

Conversation

@MallikarjunaReddyN

Copy link
Copy Markdown
Contributor

SUMMARY

Fixes an issue where result sets overlap when switching between tabs in the View as Table modal for mixed charts.

The root cause was a custom CSS override applied to Ant Design tab panes:

.ant-tabs-tabpane {
  display: flex;
  flex-direction: column;
}

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot Bot added the explore:design Related to the Explore UI/UX label Jul 14, 2026
@bito-code-review

bito-code-review Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #cb8375

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 5fdaf18..5fdaf18
    • superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 5fdaf18
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a55d2cc3f612700090673b8
😎 Deploy Preview https://deploy-preview-42018--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@rusackas

Copy link
Copy Markdown
Member

Thanks @MallikarjunaReddyN!

This .ant-tabs-tabpane { display: flex; flex-direction: column } rule was added in #21282 specifically to keep the header/pagination pinned while multi-query 'View as Table' results scroll. Removing it outright fixes the overlap you're showing, but did you check the original scroll-behind-header bug hasn't come back for the multi-query case?

The shared Tabs component only applies height: 100% to .ant-tabs-tabpane when fullHeight is passed, and it isn't here, so nothing's replacing what you're deleting.

TESTING INSTRUCTIONS is blank on the PR template, and there's no test covering scroll behavior either way, Also needs a rebase, it's conflicting agianst master now. Holler if I can help get this across the finish line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

explore:design Related to the Explore UI/UX size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants