Skip to content

fix(amber): correct WorkerSpec input port to stop flaky timeouts #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ma77Ball wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix(amber): correct WorkerSpec input port to stop flaky timeouts #6037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4485492
only return exceptions to the user and fixed the flaky test case foun…
Ma77Ball Jun 30, 2026
12c1107
Clarify error handling comment in AsyncRPCServer
Ma77Ball Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions amber/src/main/scala/org/apache/texera/amber/engine/common/rpc/AsyncRPCServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ class AsyncRPCServer(
// if error occurs, return it to the sender.
logger.error("Exception occurred", err)
returnResult(senderID, id, mkControlError(err))
// if throw this exception right now, the above message might not be able
// to be sent out. We do not throw for now.
// throw err
// Re-throw Errors (e.g. failed assertions) after replying; only
// Exceptions are returned to the sender and recovered from.
if (err.isInstanceOf[Error]) throw err
}
}

Expand Down
2 changes: 1 addition & 1 deletion amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/WorkerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class WorkerSpec
)
val addPort1 = AsyncRPCClient.ControlInvocation(
METHOD_ASSIGN_PORT,
AssignPortRequest(mockPortId, input = true, mkSchema(1).toRawSchema, List(""), List()),
AssignPortRequest(mockPortId, input = true, mkSchema(1).toRawSchema, List(), List()),
AsyncRPCContext(CONTROLLER, identifier1),
1
)
Expand Down
Loading