chore(deps): update aws-java-sdk-v2 monorepo to v2.53.1 - #7723
Open
renovate-bot wants to merge 3 commits into
Open
chore(deps): update aws-java-sdk-v2 monorepo to v2.53.1#7723renovate-bot wants to merge 3 commits into
renovate-bot wants to merge 3 commits into
Conversation
forking-renovate
Bot
added
the
dependencies
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7723 +/- ##
============================================
- Coverage 90.94% 90.93% -0.01%
+ Complexity 4454 4450 -4
============================================
Files 1175 1174 -1
Lines 47140 47139 -1
Branches 5284 5284
============================================
- Hits 42871 42866 -5
- Misses 2580 2581 +1
- Partials 1689 1692 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 541 | 0.33 | 17,821/22,971/22,971 us | 🔴 +11.7% / 🔴 +42.1% |
| 🔴 | bs=100 sw=10 sl=64 | 1,201 | 0.733 | 80,611/131,476/131,476 us | 🔴 +29.7% / 🔴 +24.5% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,418 | 0.866 | 708,535/754,740/754,740 us | ⚪ within ±5% / 🟢 +34.3% |
Baseline details
Latest main 256c2d1 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 541 tuples/sec | 606 tuples/sec | 784.16 tuples/sec | -10.7% | -31.0% |
| bs=10 sw=10 sl=64 | MB/s | 0.33 MB/s | 0.37 MB/s | 0.479 MB/s | -10.8% | -31.1% |
| bs=10 sw=10 sl=64 | p50 | 17,821 us | 15,948 us | 12,626 us | +11.7% | +41.1% |
| bs=10 sw=10 sl=64 | p95 | 22,971 us | 25,524 us | 16,169 us | -10.0% | +42.1% |
| bs=10 sw=10 sl=64 | p99 | 22,971 us | 25,524 us | 18,986 us | -10.0% | +21.0% |
| bs=100 sw=10 sl=64 | throughput | 1,201 tuples/sec | 1,238 tuples/sec | 1,023 tuples/sec | -3.0% | +17.4% |
| bs=100 sw=10 sl=64 | MB/s | 0.733 MB/s | 0.756 MB/s | 0.625 MB/s | -3.0% | +17.3% |
| bs=100 sw=10 sl=64 | p50 | 80,611 us | 80,867 us | 99,185 us | -0.3% | -18.7% |
| bs=100 sw=10 sl=64 | p95 | 131,476 us | 101,394 us | 105,616 us | +29.7% | +24.5% |
| bs=100 sw=10 sl=64 | p99 | 131,476 us | 101,394 us | 113,681 us | +29.7% | +15.7% |
| bs=1000 sw=10 sl=64 | throughput | 1,418 tuples/sec | 1,408 tuples/sec | 1,057 tuples/sec | +0.7% | +34.2% |
| bs=1000 sw=10 sl=64 | MB/s | 0.866 MB/s | 0.859 MB/s | 0.645 MB/s | +0.8% | +34.3% |
| bs=1000 sw=10 sl=64 | p50 | 708,535 us | 715,558 us | 965,435 us | -1.0% | -26.6% |
| bs=1000 sw=10 sl=64 | p95 | 754,740 us | 772,177 us | 1,012,135 us | -2.3% | -25.4% |
| bs=1000 sw=10 sl=64 | p99 | 754,740 us | 772,177 us | 1,042,088 us | -2.3% | -27.6% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,369.47,200,128000,541,0.330,17820.67,22970.60,22970.60
1,100,10,64,20,1665.17,2000,1280000,1201,0.733,80610.78,131476.43,131476.43
2,1000,10,64,20,14101.13,20000,12800000,1418,0.866,708534.52,754739.51,754739.51
The 2.29.51 -> 2.53.1 bump swaps `apache-client` for `apache5-client` and splits `utils-lite` out of `utils`, so every dist that bundles the S3 client fails `check_binary_deps.py` on a new/stale jar plus direct version drift, and `generate_notice_binary.py` no longer reproduces the committed NOTICE-binary. Per dist (amber, computing-unit-managing-service, file-service, workflow-compiling-service): | Change | Jars | | --- | --- | | added | `apache5-client`, `utils-lite` | | removed | `apache-client` | | version | 30 `software.amazon.awssdk.*` claims -> 2.53.1 | | version | `httpclient5` 5.4.3 -> 5.6.4, `httpcore5`/`-h2` 5.3.4 -> 5.4.3 | | version | `httpcore` 4.4.16 -> 4.4.13 (services only; dropped with `apache-client`) | `apache5-client` and `utils-lite` carry the same Apache-2.0 `META-INF/LICENSE.txt` as the rest of the SDK, so they join the existing awssdk bullets under the Apache License 2.0 section. NOTICE-binary is regenerated from the same jar set, which also picks up the reworded `third-party-jackson-core` notice (FastDoubleParser -> Schubfach) that shifts the surrounding blocks. Verified locally against the resolved runtime classpath of all four dists (402 / 339 / 302 / 314 jars) — `check_binary_deps.py` passes in both PR (`--ignore-transitive-version`) and exact nightly mode, and `generate_notice_binary.py` output matches byte for byte.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
`amber-integration` hit its 25-minute cap on both runners with this bump
(main is consistently green in 10-14 min). The cause is not a slow test:
java.lang.NoClassDefFoundError:
software/amazon/awssdk/http/apache/ApacheHttpClient$Builder
at org.apache.iceberg.aws.HttpClientProperties
.loadHttpClientConfigurations(HttpClientProperties.java:246)
at org.apache.iceberg.aws.s3.S3FileIO.newOutputFile(S3FileIO.java:193)
at ...storage.result.iceberg.IcebergTableWriter.close(:151)
at ...worker.managers.OutputPortStorageWriterThread.run(:63)
`iceberg-aws` 1.9.2 declares no AWS SDK dependency of its own (it is
`compileOnly` upstream), so it takes whatever transport the consumer
puts on the classpath. It supports exactly two client types, `apache`
and `urlconnection`, defaults to `apache`, and resolves that one
reflectively through `DynMethods`. AWS SDK 2.53 swapped `s3`'s
transitive transport from `apache-client` to `apache5-client`, so the
class Iceberg reflects on disappeared. The lookup raises an `Error`
rather than one of the checked exceptions `DynMethods` catches, which
kills the storage writer thread mid-`close()`; the result never lands
and the workflow retries every 90s until the job cap.
So declare the 4.x transport explicitly and exclude `apache5-client`
until Iceberg supports it — with both present the SDK picks one by
priority and logs a warning, which is worse than choosing.
Net effect on the bundled jars is now just the SDK bump plus the
`utils-lite` split: pinning `apache-client` also restores
`httpclient5` 5.4.3, `httpcore5`/`-h2` 5.3.4 and `httpcore` 4.4.16, so
the licensing churn from the previous commit shrinks accordingly.
`check_binary_deps.py` passes in exact mode and
`generate_notice_binary.py` matches for all four dists
(402 / 339 / 302 / 314 jars).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.29.51→2.53.12.29.51→2.53.12.29.51→2.53.12.29.51→2.53.1Configuration
📅 Schedule: (in timezone Etc/UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.