Add in a vendor copy of Google Highway#13228
Open
phongn wants to merge 3 commits into
Open
Conversation
Contributor
|
Do we really need to copy the lib in our repo? I thought let CMake to find the external library like what we do for jemalloc, hwloc, ...etc. https://github.com/apache/trafficserver/blob/master/cmake/Findjemalloc.cmake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Highway is a C++ library that provides portable SIMD/vector intrinsics. It currently supports all targets that ATS intends to build for (notably x86_64 and aarch64), and offers runtime dynamic dispatch.
Profiling of ATS indicates we have a number of string processing hotspots that are amenable to vector acceleration. However, each microarchitecture has different intrinsics and on x86_64 this varies wildly. Rather than take up the maintenance burden of maintaining and updating hand-written intrinsic code, we instead can use Highway to generate it for us.
This pull request adds a snapshot of Highway 1.4.0, but without tests, documentation or non-CMake build infrastructure.