Move some directory helpers to Directory#13245
Open
JosiahWI wants to merge 5 commits into
Open
Conversation
JosiahWI
force-pushed
the
refactor/directory-private-methods
branch
from
288815b to
f8f97d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on #11945 which @masaori335 requested. It moves a handful of helper functions (those that need to access members of
Directory) to theDirectorytype, so that they become methods. Some of them wereinline; I have kept theminlineto preserve the intent, so those function definitions have been moved to the header file.