Skip to content

fix: Cold self-review found the libinfo.py fix duplicated an existing#20033

Open
singlaamitesh wants to merge 1 commit into
apache:mainfrom
singlaamitesh:fix/20031-tvm-20031
Open

fix: Cold self-review found the libinfo.py fix duplicated an existing#20033
singlaamitesh wants to merge 1 commit into
apache:mainfrom
singlaamitesh:fix/20031-tvm-20031

Conversation

@singlaamitesh

Copy link
Copy Markdown

Fixes #20031

Summary

Cold self-review found the libinfo.py fix duplicated an existing mechanism (tvm.contrib.cutlass.has_cutlass(), which already probes the 'relax.ext.cutlass' global function registered only under USE_CUTLASS=ON) using a different, less-canonical symbol, and was missing the codebase's standard import-outside-toplevel pylint-disable on a local import. Aligned libinfo() to check the same 'relax.ext.cutlass' symbol as has_cutlass(), and updated both regression tests to call has_cutlass() directly instead of re-deriving the check. The GEMM ${A_arg}->${lhs_arg} template fix and the missing tvm/ffi/container/tensor.h header fix were re-verified unchanged and correct.

Changes

  • python/tvm/support/libinfo.py
  • python/tvm/contrib/cutlass/gemm_operation.py
  • python/tvm/contrib/cutlass/gen_tensor_op.py
  • tests/python/support/test_libinfo.py
  • tests/python/testing/test_env.py
  • tests/python/contrib/test_cutlass_gemm.py

How this was tested

Ran tests/ locally.

Copilot AI review requested due to automatic review settings July 20, 2026 04:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes issues with CUTLASS template instantiation and build flag detection. Specifically, it corrects an undefined template variable (${A_arg} to ${lhs_arg}) in gemm_operation.py, adds the missing tvm/ffi/container/tensor.h header in gen_tensor_op.py, and dynamically detects whether USE_CUTLASS is enabled by probing for the registered native global function instead of hardcoding it to OFF. Unit tests have been added to verify these fixes. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Relax][CUTLASS] CUTLASS tests are silently skipped, masking GEMM codegen and TVM-FFI ABI regressions

2 participants