Add Thrift interpreter RPC contract tests - #5375
Draft
jongyoul wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is the first test-only slice (G-01A) of the Server-Interpreter RPC migration work.
The existing
RemoteInterpreterServerTestcalls the service implementation directly. This PR adds a real Thrift wire characterization test usingTSocket,TBinaryProtocol, the generated client, and the generated processor.It freezes these current control-plane behaviors:
InterpreterRPCExceptionfailures kept distinct from a raw Thrift transport failureThis PR does not change production code or behavior. It intentionally characterizes the current Thrift path; it is not yet the transport-neutral harness that later gRPC tests will use.
Out of scope for this slice: callback/event RPCs, pooled-client retry and deadlines, shutdown ambiguity, recovery, Angular/resource/application/library operations, and the legacy
openRPC that currently has no production caller.What type of PR is it?
Improvement
Todos
zeppelin-interpretertest suiteWhat is the Jira issue?
TBD. This is kept as a draft until the planned RPC migration Epic and G-01A child issue are assigned. No JIRA issue was created or modified as part of this PR.
How should this be tested?
Local results:
zeppelin-interpretermodule: 129 passedScreenshots (if appropriate)
Not applicable.
Questions: