[ZEPPELIN-4495] Unify REST and WebSocket authentication with Shiro - #5376
Draft
jongyoul wants to merge 5 commits into
Draft
[ZEPPELIN-4495] Unify REST and WebSocket authentication with Shiro#5376jongyoul wants to merge 5 commits into
jongyoul wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Zeppelin currently authenticates REST requests through Shiro while notebook WebSocket connections use a separate client-provided principal/ticket flow. This PR establishes one server-side Shiro session identity for both transports.
The implementation:
/api/*and the/wsHTTP upgrade through the same Shiro filterprincipal,roles, andticketmessage fields as authentication credentials[urls]rules as the common include/exclude policy, including explicit/ws = authcor/ws = anonWhat type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4495
Related work and overlap:
NoteManager. This PR includes the overlapping serialization plus authorization/metadata generation checks, folder and revision operations, and repository compensation/reconciliation needed to keep a checked identity/ACL bound to one path generation while preserving existing-folder merge behavior.conf/shiro.ini.templatefor an unrelated documentation-link correction.brace-expansionoverride moves from 5.0.8 to 5.0.9 for GHSA-rgw5-rvv9-x895, while the lockfile movesfast-urito 3.1.5 andundicito 7.29.0 for newly published advisories.npm auditreports 0 vulnerabilities.This remains intentionally a draft while overlap with those contributions is coordinated.
How should this be tested?
Local verification completed from current
apache/master(404866f4171efa27abdf327a4f3d9ffaf3771909):zeppelin-server: 1,693 tests, 0 failures/errors, 21 skippedvalidate -Pinclude-hadoopnpm auditreports 0 vulnerabilities, Vitest 14/14, lint and production build passScreenshots (if appropriate)
N/A
Questions: