test(e2e): fix propagation race in background-health short-stale-window case#795
Conversation
…asserting eagerly The short-stale-window case read /admin/v1/models/status immediately after seeding the model and asserted the row exists. Config propagation is asynchronous, so on a loaded CI runner the immediate read races the snapshot refresh and fails with 'expected undefined to be truthy' (seen on the aisix#794 run; the test is otherwise unrelated to that PR). Poll via waitConfigPropagation like the unhealthy-transition check right below already does - same scenario, no eager race.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
The short-stale-window case reads
/admin/v1/models/statusimmediately after seeding the model and asserts the row exists. Config propagation is asynchronous, so on a loaded CI runner the immediate read races the snapshot refresh and fails withexpected undefined to be truthy— hit on an unrelated PR's e2e run (#794'se2e (vitest) + coveragejob, where the only delta was acargo fmtcommit).Fix: poll for the row via
waitConfigPropagation, exactly like the unhealthy-transition check a few lines below already does. The scenario is unchanged — the row must appear and then go unhealthy; only the eager, un-waited existence assert is gone.Verified locally: the file's 2 tests pass; the fix only touches the racy setup assert.