Remove server-side shutdown banner; rely on client-side overlay#67
Merged
Conversation
The client-side reconnect overlay (added in #59) now covers every stop, so the racy direct-socket banner, the migrating/aborting notices, and shutdown.ts are redundant. Delete them — the idle timeout just calls Actor.exit. Repoint the ttyd pin rationale at the overlay strings the injected client script matches. https://claude.ai/code/session_0127nqswxmANoa8VfkmRArmY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGTERM/SIGINThandlers, and a dying process can't reliably flush a banner).shutdown.ts, the direct-socket writes, and themigrating/aborting/idle banners; the idle timeout just callsActor.exit.Generated by Claude Code