feat(install): single-bundle install/upgrade scripts#1219
Open
vladfrangu wants to merge 1 commit into
Open
Conversation
Update the public install.sh, install.ps1 and upgrade.ps1 to the single-bundle layout: download the one apify-cli bundle and delegate wrapper-script creation to 'apify-cli install [--shims-only]' (the bundle is the single source of truth for the apify/actor shims), instead of dropping three binaries or hand-rolling the shim text. - install.sh: detect the Windows ARM64 (MINGW) target; download apify-cli; run 'apify-cli install' for shims + shell integration - install.ps1: detect arch via PROCESSOR_ARCHITECTURE (no baseline for ARM64); download apify-cli.exe; run 'apify-cli install --shims-only' - upgrade.ps1: download the single apify-cli bundle and run 'apify-cli install --shims-only'; clean up legacy .exe leftovers Depends on the single-apify-cli-bundle work, so merge this only once a release containing that bundle (and the --shims-only flag) is out.
vladfrangu
force-pushed
the
feat/single-cli-bundle-install-scripts
branch
from
c0a7362 to
d725406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the public install/upgrade scripts to the single-
apify-cli-bundle layout:install.sh— detect the Windows ARM64 (MINGW) target; download the singleapify-clibundle; runapify-cli installto create theapify/actorwrapper scripts and do shell integration (instead of dropping three binaries).install.ps1— detect arch viaPROCESSOR_ARCHITECTURE(ARM64 never uses a baseline build); downloadapify-cli.exe; runapify-cli install --shims-onlyto create the.cmd/.ps1/POSIX wrappers.upgrade.ps1— download the singleapify-clibundle and runapify-cli install --shims-only; clean up legacy.exeleftovers.The bundle is the single source of truth for the wrapper-script content; these scripts just bootstrap and delegate to it.
Depends on #1169 — merge after a release
Important
These scripts download the
apify-cli-*release asset and callapify-cli install --shims-only, both of which only exist once #1169 has shipped in a release. Merge this only after #1169 is released, otherwise installs/upgrades will break.Split out from #1169 so the public-facing install scripts can be reviewed and landed separately, on the release cadence.