ADFA-5088: Individual tooltips for every Preferences and Plugin Manager item

app/src/main/java/com/itsaky/androidide/activities/PluginManagerActivity.kt

@@ -24,19 +24,21 @@ import com.itsaky.androidide.R
 import com.itsaky.androidide.adapters.PluginListAdapter
 import com.itsaky.androidide.app.EdgeToEdgeIDEActivity
 import com.itsaky.androidide.databinding.ActivityPluginManagerBinding
-import com.itsaky.androidide.idetooltips.TooltipManager
 import com.itsaky.androidide.idetooltips.TooltipTag
 import com.itsaky.androidide.plugins.PluginInfo
 import com.itsaky.androidide.ui.models.PluginManagerUiEffect
 import com.itsaky.androidide.ui.models.PluginManagerUiEvent
 import com.itsaky.androidide.utils.DURATION_INDEFINITE
 import com.itsaky.androidide.utils.DialogUtils.showRestartPrompt
 import com.itsaky.androidide.utils.UrlManager
+import com.itsaky.androidide.utils.displayTooltipOnLongPress
 import com.itsaky.androidide.utils.errorIcon
 import com.itsaky.androidide.utils.flashError
 import com.itsaky.androidide.utils.flashSuccess
 import com.itsaky.androidide.utils.flashbarBuilder
 import com.itsaky.androidide.utils.getFileName
+import com.itsaky.androidide.utils.onLongPress
+import com.itsaky.androidide.utils.showIdeCategoryTooltipIfPresent
 import com.itsaky.androidide.utils.showOnUiThread
 import com.itsaky.androidide.viewmodels.PluginManagerViewModel
 import kotlinx.coroutines.launch
@@ -119,9 +121,8 @@ class PluginManagerActivity : EdgeToEdgeIDEActivity() {
 	override fun onCreateOptionsMenu(menu: Menu): Boolean {
 		menuInflater.inflate(R.menu.menu_plugin_manager, menu)
 		binding.toolbar.post {
-			binding.toolbar.findViewById<View>(R.id.action_discover_plugins)?.setOnLongClickListener { view ->
-				TooltipManager.showIdeCategoryTooltip(this, view, TooltipTag.PLUGIN_MANAGER)
-				true
+			binding.toolbar.findViewById<View>(R.id.action_discover_plugins)?.let { view ->
+				view.displayTooltipOnLongPress(this, TooltipTag.PLUGIN_MANAGER_DOWNLOAD)
 			}
 		}
 		return true
@@ -177,24 +178,26 @@ class PluginManagerActivity : EdgeToEdgeIDEActivity() {
 	}
 
 	private fun setupTooltipLongPress() {
-		val showTooltip: (View) -> Unit = { view ->
-			TooltipManager.showIdeCategoryTooltip(this, view, TooltipTag.PLUGIN_MANAGER)
-		}
-		binding.toolbar.setOnLongClickListener {
-			showTooltip(it)
-			true
-		}
-		binding.fabInstallPlugin.setOnLongClickListener {
-			showTooltip(it)
-			true
+		val show: (View, String) -> Unit = { view, tag ->
+			view.displayTooltipOnLongPress(this, tag)
 		}
-		binding.emptyState.setOnLongClickListener {
-			showTooltip(it)
-			true
-		}
-		binding.recyclerView.setOnLongClickListener {
-			showTooltip(it)
-			true
+		show(binding.toolbar, TooltipTag.PLUGIN_MANAGER_TOOLBAR)
+		show(binding.fabInstallPlugin, TooltipTag.PLUGIN_MANAGER_FAB_INSTALL)
+		show(binding.emptyState, TooltipTag.PLUGIN_MANAGER_EMPTY_STATE)
+
+		// A plain setOnLongClickListener on a RecyclerView never fires - it overrides
+		// onTouchEvent() for scroll handling and doesn't run the base View long-press
+		// detection - so empty list space needs the same GestureDetector-based approach
+		// used for IDEPreferencesFragment's RecyclerView. Skipped when a row is under the
+		// touch point since each row already shows its own tooltip (PluginListAdapter).
+		binding.recyclerView.onLongPress { e ->
+			// _binding directly, not the checkNotNull-backed binding getter: the ~500ms long-press
+			// timer can fire after the activity (and its binding) is destroyed.
+			val recyclerView = _binding?.recyclerView ?: return@onLongPress
+			if (recyclerView.findChildViewUnder(e.x, e.y) != null) {
+				return@onLongPress
+			}
+			showIdeCategoryTooltipIfPresent(this, recyclerView, TooltipTag.PLUGIN_MANAGER_LIST)
 		}
 	}
 

app/src/main/java/com/itsaky/androidide/activities/PreferencesActivity.kt

@@ -17,9 +17,6 @@
 package com.itsaky.androidide.activities
 
 import android.os.Bundle
-import android.view.GestureDetector
-import android.view.HapticFeedbackConstants
-import android.view.MotionEvent
 import android.view.View
 import androidx.core.graphics.Insets
 import androidx.core.os.BundleCompat
@@ -29,10 +26,12 @@ import com.itsaky.androidide.R
 import com.itsaky.androidide.app.EdgeToEdgeIDEActivity
 import com.itsaky.androidide.databinding.ActivityPreferencesBinding
 import com.itsaky.androidide.fragments.IDEPreferencesFragment
-import com.itsaky.androidide.idetooltips.TooltipManager
+import com.itsaky.androidide.idetooltips.TooltipTag
 import com.itsaky.androidide.preferences.PluginSettingsEntryPreference
 import com.itsaky.androidide.preferences.addRootPreferences
 import com.itsaky.androidide.preferences.pluginSettingsPreferences
+import com.itsaky.androidide.utils.onLongPress
+import com.itsaky.androidide.utils.showIdeCategoryTooltipIfPresent
 import com.itsaky.androidide.preferences.IDEPreferences as prefs
 
 class PreferencesActivity : EdgeToEdgeIDEActivity() {
@@ -50,20 +49,6 @@ class PreferencesActivity : EdgeToEdgeIDEActivity() {
 	 */
 	private var contributedPreferences: List<PluginSettingsEntryPreference>? = null
 
-	private val gestureDetector by lazy {
-		GestureDetector(
-			this,
-			object : GestureDetector.SimpleOnGestureListener() {
-				override fun onLongPress(e: MotionEvent) {
-					binding.root.performHapticFeedback(HapticFeedbackConstants.LONG_PRESS)
-					val currentFragment = supportFragmentManager.findFragmentById(binding.fragmentContainer.id) as? IDEPreferencesFragment
-					val tooltipTag = currentFragment?.getCurrentScreenTooltip() ?: ""
-					TooltipManager.showIdeCategoryTooltip(this@PreferencesActivity, binding.root, tooltipTag)
-				}
-			},
-		)
-	}
-
 	override fun onCreate(savedInstanceState: Bundle?) {
 		super.onCreate(savedInstanceState)
 
@@ -72,6 +57,21 @@ class PreferencesActivity : EdgeToEdgeIDEActivity() {
 		supportActionBar!!.setDisplayHomeAsUpEnabled(true)
 
 		binding.toolbar.setNavigationOnClickListener { onBackPressedDispatcher.onBackPressed() }
+		binding.toolbar.setOnLongClickListener {
+			// No manual haptic feedback: the platform already fires it for a listener returning true.
+			showScreenTooltip(_binding?.toolbar, playHapticFeedback = false)
+			true
+		}
+
+		// Fallback for a long-press that lands below a short screen's content: the RecyclerView is
+		// wrap_content-sized to its own rows, so on a short screen (e.g. Git, About) it doesn't fill
+		// this NestedScrollView, and the remaining space would otherwise have no tooltip at all.
+		// A plain setOnLongClickListener never fires here - NestedScrollView overrides onTouchEvent()
+		// for its own drag/fling handling, same as RecyclerView - so this needs the GestureDetector-
+		// based View.onLongPress instead.
+		binding.fragmentContainerParent.onLongPress {
+			showScreenTooltip(_binding?.fragmentContainerParent, playHapticFeedback = true)
+		}
 
 		feedbackButtonManager =
 			FeedbackButtonManager(
@@ -107,6 +107,7 @@ class PreferencesActivity : EdgeToEdgeIDEActivity() {
 			IDEPreferencesFragment.EXTRA_CHILDREN,
 			ArrayList(prefs.children),
 		)
+		args.putString(IDEPreferencesFragment.EXTRA_SCREEN_TOOLTIP_TAG, prefs.tooltipTag)
 
 		// A fresh instance every time: arguments cannot be set on a fragment whose state was saved.
 		loadFragment(IDEPreferencesFragment().also { it.arguments = args })
@@ -157,16 +158,31 @@ class PreferencesActivity : EdgeToEdgeIDEActivity() {
 		super.loadFragment(fragment, binding.fragmentContainer.id)
 	}
 
+	/** The tag of whichever [IDEPreferencesFragment] screen is currently on top, or [TooltipTag.PREFS_TOP]. */
+	private fun currentScreenTooltipTag(): String {
+		val fragment = supportFragmentManager.findFragmentById(binding.fragmentContainer.id)
+		return (fragment as? IDEPreferencesFragment)?.screenTooltipTag ?: TooltipTag.PREFS_TOP
+	}
+
+	/**
+	 * Shows the current screen's tooltip anchored to [view], or does nothing if it's null - both
+	 * call sites pass `_binding?.someView` directly rather than the checkNotNull-backed [binding]
+	 * getter, since a long-press timer (or a listener callback) can fire after the activity (and
+	 * its binding) has already been destroyed.
+	 */
+	private fun showScreenTooltip(
+		view: View?,
+		playHapticFeedback: Boolean,
+	) {
+		view ?: return
+		showIdeCategoryTooltipIfPresent(this, view, currentScreenTooltipTag(), playHapticFeedback)
+	}
+
 	override fun onDestroy() {
 		super.onDestroy()
 		_binding = null
 	}
 
-	override fun dispatchTouchEvent(ev: MotionEvent): Boolean {
-		gestureDetector.onTouchEvent(ev)
-		return super.dispatchTouchEvent(ev)
-	}
-
 	override fun onSaveInstanceState(outState: Bundle) {
 		super.onSaveInstanceState(outState)
 		contributedPreferences?.let {

app/src/main/java/com/itsaky/androidide/adapters/PluginListAdapter.kt

@@ -14,9 +14,9 @@ import com.bumptech.glide.Glide
 import com.bumptech.glide.signature.ObjectKey
 import com.itsaky.androidide.R
 import com.itsaky.androidide.databinding.ItemPluginBinding
-import com.itsaky.androidide.idetooltips.TooltipManager
 import com.itsaky.androidide.idetooltips.TooltipTag
 import com.itsaky.androidide.plugins.PluginInfo
+import com.itsaky.androidide.utils.displayTooltipOnLongPress
 import com.itsaky.androidide.utils.isSystemInDarkMode
 import java.io.File
 
@@ -55,6 +55,13 @@ class PluginListAdapter(
 	inner class PluginViewHolder(
 		private val binding: ItemPluginBinding,
 	) : RecyclerView.ViewHolder(binding.root) {
+		init {
+			// Both the anchor views and their tags are fixed per view holder, not per bound plugin -
+			// register once here instead of re-registering an identical listener on every bind().
+			binding.btnMenu.displayTooltipOnLongPress(itemView.context, TooltipTag.PLUGIN_MANAGER_ITEM_MENU)
+			binding.root.displayTooltipOnLongPress(itemView.context, TooltipTag.PLUGIN_MANAGER_ITEM)
+		}
+
 		fun bind(plugin: PluginInfo) {
 			binding.apply {
 				pluginName.text = plugin.metadata.name
@@ -120,12 +127,6 @@ class PluginListAdapter(
 				root.setOnClickListener {
 					onActionClick(plugin, Action.DETAILS)
 				}
-
-				// Long-press for Plugin Manager tooltip
-				root.setOnLongClickListener {
-					TooltipManager.showIdeCategoryTooltip(it.context, it, TooltipTag.PLUGIN_MANAGER)
-					true
-				}
 			}
 		}