ADFA-5192 refactor(terminal): re-home the Debian terminal into TerminalActivity - #433
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-homes the Debian terminal out of the legacy MainActivity into its own thin
TerminalActivity, so MainActivity and the dead legacy tabbed UI can be removed
(ADFA-5192, Phase B — the deletion is Phase A / a separate PR).
Changes
TerminalActivity(new): loads the nativetermuxengine, hosts the terminallayout, implements
TerminalController.Host(addToLog→LogRepository,vibrateDevice). All terminal behaviour stays inTerminalController, unchanged.terminal_activity.xml(new): theterminal_bottom_sheetsubtree (drag handle,drawer,
TerminalView, extra keys) lifted frommain.xml, kept as aBottomSheetBehaviorchild of aCoordinatorLayoutsoTerminalController.bind()works without changes. Swipe-down finishes back to the caller, as the old
terminal-only mode did.
TerminalActivitydeclared (not exported,singleTop,adjustResizeconfigChanges— the same window/IME setup MainActivity used for the terminal).TerminalActivitydirectly (no terminal-only extras):TerminalSessionService(keep-alive notification) andredesign/SettingsSubFragment(Settings → Terminal).
Notes
TerminalControlleris untouched — it was already host-agnostic (finds its viewIDs + the 2-callback Host).
by either caller. It is removed in Phase A.
the layout's dark hex is carried over as-is; M3 token restyling is out of scope
for a behaviour-preserving re-home.
Verification
Device build + manual: open the terminal from Settings → Terminal (Debian) and from
the keep-alive notification; type with the extra-keys bar over the keyboard;
swipe-down returns to the redesign. Sessions survive across open/close (app-scoped
session store).