ADFA-5192 refactor(system): extract SystemState enum out of DashboardFragment - #434
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for retiring the legacy tabbed UI (ADFA-5192, Phase A · Step 1).
SystemStatewas a nested enum in the legacy
DashboardFragment, but three kept classes depend onit (
ServerState,ServerController,SystemStateEvaluator) — the one real couplingbetween live code and the doomed fragment. Extract it to a top-level
org.iiab.controller.SystemStateso it survives the deletion.No behaviour change. All users are in the same package, so references resolve to the
new top-level enum unchanged.
Changes
SystemState(top-level enum, same six values).DashboardFragment: nested enum removed.DashboardFragment.SystemState→SystemStateinServerState,ServerController,SystemStateEvaluator,UsageFragment, and aTier3LinkResolverdoc comment.
Verification
No remaining
DashboardFragment.SystemStatereferences in code; the redesign readsSystemStatethroughServerState/ServerStateRepositoryas before.