ADFA-5192 refactor(install): retire the dead companion install leg - #436
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires the companion install leg in InstallService, dead since ADFA-5192 Step 2
removed InstallController (the only caller that set EXTRA_COMPANION=true). Behaviour-
preserving: companionData was already always false, so the two
if (companionData)…guards already took the
finishSuccess()branch — this just makes that literal.Removed
runMapsAnsible, editLocalVarsForMaps.
(no setter existed), EXTRA_SKIP_MAPS/skipMaps (read only by runMapsAnsible),
restContentClient (+ its now-inert cancel guard), two unused imports.
Closes the ADFA-5144 leg
This was the only path that could report a failed ZIM download/index as a SUCCESSFUL
install. It is gone; the modern wizard banks content honestly through the live channel.
Verification
No references to any removed symbol remain. Fresh install / module install / reinstall
paths are unchanged (companionData was already always false). Build green + device smoke.