Add runtime abstraction plumbing#1701
Open
ajemory wants to merge 2 commits into
Open
Conversation
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This is part 1 of 2 of the APIServer runtime abstraction (#1376)
This change introduces plumbing to remove Linux specific data (i.e. Kernel and initfs) from ContainersService, and moves that runtime specific information/functionality to the CLI or Runtime service as needed.
While this PR changes the shape of the RuntimeConfiguration, the bundle shape remains unchanged. This means that old containers that have been started function as intended (read directly from the bundle). Backwards compatibility is maintained for old containers that have not been started (old format RuntimeConfiguration is read on first start, bundle is read directly on subsequent starts).
Testing