Adjust overcommit and max_map_count vm defaults in guest VMs - #2055
Open
adityabagchi24 wants to merge 1 commit into
Open
Adjust overcommit and max_map_count vm defaults in guest VMs#2055adityabagchi24 wants to merge 1 commit into
adityabagchi24 wants to merge 1 commit into
Conversation
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Each container runs in its own guest VM sized to
--memorywith no swap, so the guest kernel's stockvmsysctl defaults are hit far too easily:vm.overcommit_memory=0(heuristic overcommit) rejects an oversizedmmap()upfront whenever the reservation exceeds the small, swap-less VM's free RAM — even if the memory is never touched — returningENOMEM.vm.max_map_count=65530caps per-process mapping count, which mapping-heavy applications (e.g. Elasticsearch, many JVMs) legitimately exceed.Fixes #2053
Motivation and Context
These stock defaults cause common oversubscribed-
mmapand many-mapping workloads to fail inside a container even though they work on a typical host. This PR applies container-friendly defaults at container start so these workloads succeed, while actual memory usage remains enforced by the container's existing--memorylimit (via cgroup memory limit and the OOM killer).Implementation
Sources/Services/RuntimeLinux/Server/RuntimeService.swift: setvm.overcommit_memory=1andvm.max_map_count=262144as defaults when configuring a container's guest sysctls.