Add reassembly support for fragmented IPv4 packets in Swift IP#32
Open
agnosticdev wants to merge 1 commit into
Open
Add reassembly support for fragmented IPv4 packets in Swift IP#32agnosticdev wants to merge 1 commit into
agnosticdev wants to merge 1 commit into
Conversation
Collaborator
Author
|
Outbound fragmentation support for IPv4 will also come in a future change. |
tfpauly
reviewed
Jun 29, 2026
| } | ||
| } | ||
|
|
||
| public mutating func prepend(frame: consuming Frame) { |
Collaborator
There was a problem hiding this comment.
The body of this function should just be
self.frames.prepend(frame)
| var log = NetworkLoggerState() | ||
| var eventManager = ProtocolEventManager() | ||
|
|
||
| static let IP_MF: UInt16 = 0x2000 |
Collaborator
There was a problem hiding this comment.
Let's make these use more swift-styled names: IPMoreFragmentsFlag, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to add reassembly support for fragmented IPv4 packets in Swift IP without impacting performance and on standard path.
Since IP fragmentation is not very common there needs to be fall-back behavior for reassembly when IP fragments are detected in
processInboundFramesto ensure performance.This change includes such fall-back behavior for reassembly and I verified the performance with QUICTransfer:
Adds support for reassembly IPv4 fragments only. IPv6 support will come in a future change.