Skip to content

fix(workflows): use continue instead of break in close-labeler loop#41986

Open
moosairfaan wants to merge 2 commits into
appsmithorg:releasefrom
moosairfaan:fix-close-labeler-continue
Open

fix(workflows): use continue instead of break in close-labeler loop#41986
moosairfaan wants to merge 2 commits into
appsmithorg:releasefrom
moosairfaan:fix-close-labeler-continue

Conversation

@moosairfaan

@moosairfaan moosairfaan commented Jul 13, 2026

Copy link
Copy Markdown

Fixes #41983
The close-labeler loop used break instead of continue, so any qualifying (Bug/Enhancement) issue that came after a non-qualifying one in a PR's closing issues list never got the QA label. Changed break to continue so the loop skips non-qualifying issues instead of aborting.

Summary by CodeRabbit

  • Bug Fixes
    • Improved automated labeling so all eligible referenced issues are processed.
    • Issues meeting the required criteria now receive the appropriate QA label without being skipped due to earlier non-matching issues.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3efa7b15-ab70-462f-8d8b-a79bf140b608

📥 Commits

Reviewing files that changed from the base of the PR and between 315b36c and 6f9932b.

📒 Files selected for processing (1)
  • .github/workflows/close-labeler.yml

Walkthrough

The close-labeler workflow now skips non-matching issue references and continues evaluating subsequent nodes, allowing all eligible issues to receive the QA label.

Changes

Close labeler behavior

Layer / File(s) Summary
Process all eligible issue references
.github/workflows/close-labeler.yml
The loop uses continue for non-matching nodes instead of stopping with break.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • appsmithorg/appsmith#41983 — Describes the same break to continue change in the close-labeler workflow.

Suggested reviewers: mohanarpit

Poem

One issue missed, then onward it flies,
The loop keeps sailing through issue skies.
Matching bugs and features align,
QA labels bloom in a tidy line.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: switching the close-labeler loop from break to continue.
Description check ✅ Passed The description includes the issue reference and a clear change summary, but omits the template's automation and communication sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@moosairfaan moosairfaan requested a review from a team as a code owner July 14, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

close-labeler workflow uses break instead of continue, dropping the QA label on multi-issue PRs

1 participant