Skip to content

feat: add Premium Geo DB addon to project settings#2981

Open
lohanidamodar wants to merge 22 commits into
mainfrom
feat/project-premium-geo-db-addon
Open

feat: add Premium Geo DB addon to project settings#2981
lohanidamodar wants to merge 22 commits into
mainfrom
feat/project-premium-geo-db-addon

Conversation

@lohanidamodar
Copy link
Copy Markdown
Member

Summary

Adds a Premium Geo DB section to the project settings page so users can enable and disable the premium geolocation addon per-project on cloud.

The section supports the full addon lifecycle, mirroring the BAA pattern at the organization level:

  • Upgrade prompt when the current plan does not support the addon
  • Enable flow with optional 3DS payment authentication
  • Pending state with cancel & retry option (if payment was interrupted)
  • Active state with disable action
  • Scheduled-for-removal state with re-enable action

Uses the new project-scoped SDK methods shipped with the cloud update: listAddons, createPremiumGeoDBAddon, and deleteAddon. Bumps the @appwrite.io/console SDK pin accordingly.

Test plan

  • Navigate to a cloud project's settings as an org owner on a plan that supports Premium Geo DB → section appears with Enable CTA
  • Click Enable → modal confirms and enables the addon (3DS where required); section transitions to Active
  • Click Disable → confirms removal at end of billing cycle; section transitions to Scheduled-for-removal
  • Click Keep Premium Geo DB while Scheduled-for-removal → returns to Active
  • On a plan that doesn't support the addon → shows Upgrade plan CTA / "not available" copy
  • On self-hosted mode → section is hidden

🤖 Generated with Claude Code

Adds a Premium Geo DB section to the project settings page so users
can enable and disable the premium geolocation addon per-project on
cloud. The section supports the full addon lifecycle:

- Upgrade prompt when the current plan does not support the addon
- Enable flow with optional 3DS payment authentication
- Pending state with cancel & retry option
- Active state with disable action
- Scheduled-for-removal state with re-enable action

Uses the new project-scoped SDK methods: listAddons, createPremiumGeoDBAddon,
and deleteAddon. Bumps the @appwrite.io/console SDK pin accordingly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 18, 2026

Greptile Summary

This PR adds a Premium Geo DB addon section to the project settings page, mirroring the existing BAA flow at the org level. The load function, settings page, and three new components wire up the full enable/active/pending/scheduled-for-removal lifecycle.

  • premiumGeoDB.svelte gains an onMount handler to process the ?type=confirm-addon return URL after a 3DS redirect, and delegates enable/disable actions to two new modal components.
  • planSummary.svelte removes the hardcoded billingAddonNames map in favour of addon.name and adds per-project addon rows to the billing breakdown table.
  • package.json bumps the console SDK pin to a commit that ships listAddons, createPremiumGeoDBAddon, and deleteAddon for project-scoped use.

Confidence Score: 3/5

The payment lifecycle in premiumGeoDBEnableModal and premiumGeoDB is incomplete relative to the BAA reference, leaving several real-money flows without proper feedback or recovery paths.

The SvelteKit load function and page-mount integration are solid. However, the Stripe payment handling in the enable modal and the re-enable path in the main component omit critical steps that the BAA implementation handles correctly — outcome inspection, confirmAddonPayment finalisation, and error recovery. Until those gaps are closed, users can pay without the addon activating, or receive false-success notifications while the addon remains in a pending or unconfirmed state.

premiumGeoDBEnableModal.svelte and premiumGeoDB.svelte carry the payment flow gaps; planSummary.svelte deserves a second look once the billing API behaviour around per-project addon resources is confirmed.

Important Files Changed

Filename Overview
src/routes/(console)/project-[region]-[project]/settings/premiumGeoDB.svelte New component managing the full Premium Geo DB addon lifecycle; includes an onMount 3DS return handler, but handleReEnable discards the createPremiumGeoDBAddon return value so 3DS re-enables silently fail, and the pending state has no cancel action.
src/routes/(console)/project-[region]-[project]/settings/premiumGeoDBEnableModal.svelte New enable modal; missing redirectIfRequired: true in the confirmPayment call and the outcome is not inspected, leaving the modal silent on 3DS failures; also missing confirmAddonPayment + show=false on non-redirect success path.
src/routes/(console)/project-[region]-[project]/settings/premiumGeoDBDisableModal.svelte New disable modal; correctly calls deleteAddon, invalidates state, shows notification, and closes.
src/routes/(console)/project-[region]-[project]/settings/+page.ts Load function extended to fetch addon list and addon price via Promise.allSettled; cloud-only paths use .catch(()=>null) so failures degrade gracefully to null.
src/routes/(console)/project-[region]-[project]/settings/+page.svelte Mounts PremiumGeoDB behind isCloud && $canWriteProjects guard; change is minimal and correct.
src/routes/(console)/organization-[organization]/billing/planSummary.svelte Removes hardcoded billingAddonNames map in favour of addon.name (risks blank label for BAA if API omits name), and adds per-project addon_ rows that may double-count charges already surfaced at the top-level aggregation.
package.json Pins @appwrite.io/console SDK to a specific commit hash via pkg.vc URL to pick up the new project-scoped addon APIs; pattern is consistent with other pinned packages.

Reviews (19): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile

lohanidamodar and others added 4 commits April 19, 2026 11:13
Mirrors the BAA addon UX by fetching the addon price via
organizations.getAddonPrice(Addon.Premiumgeodb) from the settings
page loader, passing it through to the Premium Geo DB card and
enable modal, and rendering the monthly/prorated breakdown with
formatCurrency alongside the Enable CTA.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…name

- Each project row in the organization billing breakdown now iterates
  its resources for addon_* entries (amount > 0) and renders them as
  child rows (e.g. Premium Geo DB under the project it was enabled on).
  The backend already filters project-scoped addons out of the
  team-level resources response, so the org "Addons" section shows only
  org-scoped addons (BAA, premiumGeoDBOrg) while project-scoped ones
  surface where they belong.
- Org-level addon labels now read addon.name from the UsageResource
  payload that the getAggregation endpoint populates from billingAddons
  config. Dropped the hard-coded billingAddonNames map so new addons
  surface with their proper name without a console update.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…geo-db-addon

# Conflicts:
#	bun.lock
#	package.json
#	src/routes/(console)/project-[region]-[project]/settings/+page.svelte
…geo-db-addon

# Conflicts:
#	bun.lock
#	package.json
…geo-db-addon

# Conflicts:
#	src/routes/(console)/project-[region]-[project]/settings/+page.svelte
#	src/routes/(console)/project-[region]-[project]/settings/+page.ts
Comment on lines +399 to +410
...resources
.filter((r) => r.resourceId?.startsWith('addon_') && (r.amount ?? 0) > 0)
.map((addon) =>
createRow({
id: `addon-${addon.resourceId}`,
label: addon.name || addon.resourceId,
resource: addon,
usageFormatter: ({ value }) => formatNum(value),
priceFormatter: ({ amount }) => formatCurrency(amount),
includeProgress: false
})
),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Possible double-counting of addon charges in plan summary

The top-level addons section (line 252–275) already creates a billing row for every addon_-prefixed resource found in currentAggregation.resources. If the billing API also surfaces those same addon resources inside projectData.resources (the per-project breakdown), each project-scoped addon (e.g. Premium Geo DB) will appear as both a top-level line item and a child row — showing the same charge twice to the user.

Before shipping, confirm whether the cloud billing API places project-level addon charges exclusively in breakdown[].resources (making the top-level filter skip them) or in both places. If the former, this code is correct; if the latter, the top-level addons filter needs to exclude resources that are already accounted for at the project level (or vice-versa).

…h for premium geoDB

Two missing pieces vs the BAA addon flow:

1. After Stripe redirects back from 3DS with ?type=confirm-addon&addonId=...,
   the page didn't read the query params or call the confirmations endpoint,
   so the addon stayed pending forever. Port the onMount handler from BAA.svelte.

2. The pending-state action was "Cancel & retry" which deleted the addon and
   forced a fresh 3DS flow. That's wasteful when the payment just needs a
   server-side status sync. Replace with "Refresh" — calls the confirmations
   endpoint, which live-queries Stripe and activates the addon if the
   PaymentIntent has transitioned to succeeded. Backend cleans up on 402.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant